support ancient versions of docker again (template parsing issue) #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
medyagh
requested changes
Feb 5, 2021
There was a problem hiding this comment.
since this PR adds support for ancient docker versions, lets remove the Exit that we used to do for old docker versions...now we can only Warn the user and say Needs imporvement...
Reason: "PROVIDER_DOCKER_VERSION_LOW",
Error: oci.ErrMinDockerVersion,
Installed: true,
Healthy: false,
NeedsImprovement: true,
Fix: fmt.Sprintf("Upgrade %s to a newer version (Minimum supproted version is %2d.%2d.%d)", driver.FullName(driver.Docker), minDockerVersion[0], minDockerVersion[1], minDockerVersion[2]),
Doc: docURL + "#requirements"}
change to not return error but instead return needs imporvement
Installed: true,
Healthy: true,
NeedsImprovement: true,
Fix: fmt.Sprintf("Upgrade %s to a newer version (Minimum supproted version is %2d.%2d.%d)", driver.FullName(driver.Docker), minDockerVersion[0], minDockerVersion[1], minDockerVersion[2]),
Doc: docURL + "#requirements"}
|
@medyagh i've removed the exit for ancient docker versions and confirmed it working (basic testing only) with the last version still available on github: also checked with v18: note: i managed to get it working with the last version still available to download as well: minikube/pkg/minikube/command/kic_runner.go Line 262 in 9d091e6 i haven't made that change into my last pr as we probably do not want/need to go that far back... |
|
I don't think we need to support Docker 17.xx or earlier, only OS that I know of that has that is CentOS 7 (1.13.1). And we don't want to support that, if you want to run CentOS you need to install a newer version from vendor: https://docs.docker.com/engine/install/centos/ For Ubuntu, the oldest that we need to support is 18.09.7: https://packages.ubuntu.com/search?keywords=docker.io |
medyagh
approved these changes
Feb 5, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
medyagh
reviewed
Feb 5, 2021
| NeedsImprovement: true, | ||
| Fix: fmt.Sprintf("Upgrade %s to a newer version (Minimum supproted version is %2d.%2d.%d)", driver.FullName(driver.Docker), minDockerVersion[0], minDockerVersion[1], minDockerVersion[2]), | ||
| Fix: fmt.Sprintf("Upgrade %s to a newer version (Minimum supproted version is %2d.%02d.%d)", driver.FullName(driver.Docker), minDockerVersion[0], minDockerVersion[1], minDockerVersion[2]), |
There was a problem hiding this comment.
nit: we could improve the wording for this
and say min recommended docker version is,
There was a problem hiding this comment.
done!
thank you for review medya
|
kvm2 Driver |
|
kvm2 Driver Times for Minikube (PR 10369): 66.7s 65.3s 65.7s Averages Time Per Log docker Driver Times for Minikube (PR 10369): 24.7s 24.1s 24.9s Averages Time Per Log |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10362
as described in the original issue/comments, this pr changes the go template used to parse
docker network inspect --formatby avoiding the operator=that was introduced in go 1.11 (ref: https://golang.org/doc/go1.11#text/template) - to support older docker versions (eg, docker v18.09.7 uses go v1.10.8)also, this pr fixes the error:
Exiting due to PROVIDER_DOCKER_NOT_RUNNING: docker version: strconv.Atoi: parsing "7\n": invalid syntaxin checkDockerVersion() while parsing the docker version - current master/main branch
before:
after:
confirmed working with newer versions: